From 180f1908b34f9cca0792d442a9deaae7f6e9beab Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Wed, 26 May 2021 22:14:10 +0200 Subject: OvmfPkg/AcpiPlatformDxe: sort #includes and [LibraryClasses] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Place all public #includes first, all module-private #includes second. Separate them with a single empty line. Keep each section sorted in itself. Sort all sections in both INF files. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Philippe Mathieu-Daudé Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 Signed-off-by: Laszlo Ersek Message-Id: <20210526201446.12554-8-lersek@redhat.com> Reviewed-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé --- OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 15 ++++++--------- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 18 +++++++++--------- OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 1 + OvmfPkg/AcpiPlatformDxe/Qemu.c | 11 ++++++----- OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 12 ++++++------ OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 2 +- OvmfPkg/AcpiPlatformDxe/Xen.c | 3 ++- 7 files changed, 31 insertions(+), 31 deletions(-) diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h index c8dee8ab7a..511a30782f 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h @@ -9,19 +9,16 @@ #ifndef ACPI_PLATFORM_H_ #define ACPI_PLATFORM_H_ -#include - -#include -#include -#include - +#include #include -#include #include #include +#include #include - -#include +#include +#include +#include +#include typedef struct { EFI_PCI_IO_PROTOCOL *PciIo; diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf index e486b8afa5..4522d7f611 100644 --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -32,24 +32,24 @@ Xen.c [Packages] - MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec OvmfPkg/OvmfPkg.dec UefiCpuPkg/UefiCpuPkg.dec [LibraryClasses] - UefiLib - PcdLib + BaseLib BaseMemoryLib DebugLib - UefiBootServicesTableLib - UefiDriverEntryPoint - QemuFwCfgLib - QemuFwCfgS3Lib - MemoryAllocationLib - BaseLib DxeServicesTableLib + MemoryAllocationLib OrderedCollectionLib + PcdLib + QemuFwCfgLib + QemuFwCfgS3Lib + UefiBootServicesTableLib + UefiDriverEntryPoint + UefiLib XenPlatformLib [Protocols] diff --git a/OvmfPkg/AcpiPlatformDxe/EntryPoint.c b/OvmfPkg/AcpiPlatformDxe/EntryPoint.c index f66f892911..fb07ed8537 100644 --- a/OvmfPkg/AcpiPlatformDxe/EntryPoint.c +++ b/OvmfPkg/AcpiPlatformDxe/EntryPoint.c @@ -8,6 +8,7 @@ **/ #include + #include "AcpiPlatform.h" STATIC diff --git a/OvmfPkg/AcpiPlatformDxe/Qemu.c b/OvmfPkg/AcpiPlatformDxe/Qemu.c index 7fb4227004..bed3b16159 100644 --- a/OvmfPkg/AcpiPlatformDxe/Qemu.c +++ b/OvmfPkg/AcpiPlatformDxe/Qemu.c @@ -9,14 +9,15 @@ **/ -#include "AcpiPlatform.h" +#include #include -#include -#include #include -#include +#include #include -#include +#include +#include + +#include "AcpiPlatform.h" BOOLEAN QemuDetected ( diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c index b62027db6e..c07b84a213 100644 --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c @@ -8,17 +8,17 @@ **/ -#include "AcpiPlatform.h" -#include "QemuLoader.h" +#include #include +#include #include +#include +#include #include #include -#include -#include -#include -#include +#include "AcpiPlatform.h" +#include "QemuLoader.h" // // The user structure for the ordered collection that will track the fw_cfg diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf index c9ec4f60bc..cc24f35bd8 100644 --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf @@ -30,8 +30,8 @@ QemuLoader.h [Packages] - MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec OvmfPkg/OvmfPkg.dec [LibraryClasses] diff --git a/OvmfPkg/AcpiPlatformDxe/Xen.c b/OvmfPkg/AcpiPlatformDxe/Xen.c index 289ef971c4..1d69989042 100644 --- a/OvmfPkg/AcpiPlatformDxe/Xen.c +++ b/OvmfPkg/AcpiPlatformDxe/Xen.c @@ -8,9 +8,10 @@ **/ -#include "AcpiPlatform.h" #include +#include "AcpiPlatform.h" + #define XEN_ACPI_PHYSICAL_ADDRESS 0x000EA020 #define XEN_BIOS_PHYSICAL_END 0x000FFFFF -- cgit v1.2.3