From 2b75e8cd093afeb1377dbdaa80a24e96e49f099b Mon Sep 17 00:00:00 2001 From: Liming Gao Date: Thu, 2 Jul 2015 04:27:32 +0000 Subject: MdeModulePkg: SecurityManagementLib to handle LoadFile DevicePath UEFI Spec HTTP Boot Device Path, after retrieving the boot resource information, the BootURI device path node will be updated to include the BootURI information. It means the device path on the child handle will be updated after the LoadFile() service is called. To handle this case, SecurityManagementLib ExecuteSecurityHandlers API is updated as the below: 1) Get Device handle based on Device Path 2) Call LoadFile() service (GetFileBufferByFilePath() API) to get Load File Buffer. 3) Retrieve DevicePath from Device handle Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Ruiyu Ni git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17797 6f19259b-4bc3-4df7-8a09-765794883524 --- .../DxeSecurityManagementLib.c | 22 ++++++++++++++++++++-- .../DxeSecurityManagementLib.inf | 8 ++++++-- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c index 6a50937ade..b96d78664d 100644 --- a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c +++ b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c @@ -1,7 +1,7 @@ /** @file Provides generic security measurement functions for DXE module. -Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.
+Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -13,10 +13,13 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. **/ #include +#include #include #include #include #include +#include +#include #define SECURITY_HANDLER_TABLE_SIZE 0x10 @@ -219,6 +222,9 @@ ExecuteSecurityHandlers ( UINT32 HandlerAuthenticationStatus; VOID *FileBuffer; UINTN FileSize; + EFI_HANDLE Handle; + EFI_DEVICE_PATH_PROTOCOL *Node; + EFI_DEVICE_PATH_PROTOCOL *FilePathToVerfiy; if (FilePath == NULL) { return EFI_INVALID_PARAMETER; @@ -235,6 +241,7 @@ ExecuteSecurityHandlers ( FileBuffer = NULL; FileSize = 0; HandlerAuthenticationStatus = AuthenticationStatus; + FilePathToVerfiy = (EFI_DEVICE_PATH_PROTOCOL *) FilePath; // // Run security handler in same order to their registered list // @@ -244,6 +251,8 @@ ExecuteSecurityHandlers ( // Try get file buffer when the handler requires image buffer. // if (FileBuffer == NULL) { + Node = FilePathToVerfiy; + Status = gBS->LocateDevicePath (&gEfiLoadFileProtocolGuid, &Node, &Handle); // // Try to get image by FALSE boot policy for the exact boot file path. // @@ -254,11 +263,17 @@ ExecuteSecurityHandlers ( // FileBuffer = GetFileBufferByFilePath (TRUE, FilePath, &FileSize, &AuthenticationStatus); } + if ((FileBuffer != NULL) && (!EFI_ERROR (Status))) { + // + // LoadFile () may cause the device path of the Handle be updated. + // + FilePathToVerfiy = AppendDevicePath (DevicePathFromHandle (Handle), Node); + } } } Status = mSecurityTable[Index].SecurityHandler ( HandlerAuthenticationStatus, - FilePath, + FilePathToVerfiy, FileBuffer, FileSize ); @@ -270,6 +285,9 @@ ExecuteSecurityHandlers ( if (FileBuffer != NULL) { FreePool (FileBuffer); } + if (FilePathToVerfiy != FilePath) { + FreePool (FilePathToVerfiy); + } return Status; } diff --git a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf index 60ac8e79f2..0f8a13b99d 100644 --- a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf +++ b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf @@ -3,7 +3,7 @@ # # This library provides generic security measurement functions for DXE module. # -# Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
+# Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.
# # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -41,4 +41,8 @@ MemoryAllocationLib DebugLib DxeServicesLib - + DevicePathLib + UefiBootServicesTableLib + +[Protocols] + gEfiLoadFileProtocolGuid ## SOMETIMES_CONSUMES -- cgit v1.2.3