From 2be4828af1c92a848af90429a9a0b44544c80553 Mon Sep 17 00:00:00 2001 From: Bob Feng Date: Thu, 27 Feb 2020 22:25:24 +0800 Subject: BaseTools: Remove invalid leading space before !INCLUDE in Makefile REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2563 This patch is to fix a incremental build regression bug which happen when using nmake. That's introduced by 818283de3f6d. If there is white space before !INCLUDE instruction, nmake will not process it. Source code's dependent header files are listed in ${deps_file} file, if it's not included successfully, nmake will not detect the change of those header file. This patch has been verified in Windows with VS2015 and Linux with GCC5. The header file add/modify/delete can trig the incremental build with this fix. There is no impact on the clean build. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Cc: Pierre Gondois Signed-off-by: Bob Feng Acked-by: Laszlo Ersek Reviewed-by: Liming Gao Tested-by: Liming Gao --- BaseTools/Source/Python/AutoGen/IncludesAutoGen.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/IncludesAutoGen.py b/BaseTools/Source/Python/AutoGen/IncludesAutoGen.py index 0a6314266f..720d93395a 100644 --- a/BaseTools/Source/Python/AutoGen/IncludesAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/IncludesAutoGen.py @@ -52,17 +52,17 @@ class IncludesAutoGen(): EdkLogger.error("build", PARAMETER_MISSING, Message="No Make path available.") elif "nmake" in MakePath: _INCLUDE_DEPS_TEMPLATE = TemplateString(''' - ${BEGIN} - !IF EXIST(${deps_file}) - !INCLUDE ${deps_file} - !ENDIF - ${END} +${BEGIN} +!IF EXIST(${deps_file}) +!INCLUDE ${deps_file} +!ENDIF +${END} ''') else: _INCLUDE_DEPS_TEMPLATE = TemplateString(''' - ${BEGIN} - -include ${deps_file} - ${END} +${BEGIN} +-include ${deps_file} +${END} ''') try: -- cgit v1.2.3