From 3399f64588428010d48c754f3743bdc8131fa270 Mon Sep 17 00:00:00 2001 From: Nickle Wang Date: Thu, 13 Jul 2023 15:01:47 +0800 Subject: RedfishPkg/RedfishRestExDxe: reset session when TCP timeout happens Call ResetHttpTslSession() to reset HTTP session when TCP timeout failure happens. So that application can perform retry to the same URI. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 4 ++-- RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h | 14 ++++++++++++++ RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 4 ++++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c index 838e24f7e7..b2961424de 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c @@ -4,6 +4,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (c) 2023, American Megatrends International LLC. + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -12,8 +13,7 @@ #include "RedfishRestExInternal.h" /** - Create a new TLS session becuase the previous on is closed. - status. + Create a new TLS session because the previous one is closed. @param[in] Instance Pointer to EFI_REST_EX_PROTOCOL instance for a particular REST service. diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h b/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h index bca679e2cc..c146f4a647 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h @@ -55,6 +55,20 @@ RedfishCheckHttpReceiveStatus ( IN EFI_STATUS HttpIoReceiveStatus ); +/** + Create a new TLS session because the previous one is closed. + + @param[in] Instance Pointer to EFI_REST_EX_PROTOCOL instance for a particular + REST service. + @retval EFI_SUCCESS operation succeeded. + @retval EFI_ERROR Other errors. + +**/ +EFI_STATUS +ResetHttpTslSession ( + IN RESTEX_INSTANCE *Instance + ); + /** This function send the HTTP request without body to see if the write to URL is permitted by Redfish service. This function diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c index d8f2c73f8e..90973619f2 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -188,6 +188,10 @@ ReSendRequest:; } if (EFI_ERROR (Status)) { + // + // Communication failure happens. Reset the session. + // + ResetHttpTslSession (Instance); goto ON_EXIT; } -- cgit v1.2.3