From 4ddf2448ed3ae87d274c593fa5a9ca91e1f3644b Mon Sep 17 00:00:00 2001 From: Ard Biesheuvel Date: Mon, 13 May 2024 18:26:51 +0200 Subject: MdePkg/BaseRngLib AARCH64: Remove overzealous ASSERT() BaseRngLib on AARCH64 will discover whether or not RNDR instructions are supported, by inspecting the ISAR0 identification register, and setting a global boolean accordingly. This boolean is used in subsequent execution to decide whether or not to issue the instruction. The same discovery code also ASSERT()s that RNDR instructions are implemented, which is unnecessary, and breaks execution on systems that incorporate the library but don't implement the instruction (or fail to expose it to the exception level that the firmware executes at). So drop the ASSERT(). Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Committed-by: Ard Biesheuvel Signed-off-by: Doug Flick [MSFT] Reviewed-by: Liming Gao --- MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/MdePkg/Library/BaseRngLib/AArch64/Rndr.c b/MdePkg/Library/BaseRngLib/AArch64/Rndr.c index d39db62153..3a556a2e3f 100644 --- a/MdePkg/Library/BaseRngLib/AArch64/Rndr.c +++ b/MdePkg/Library/BaseRngLib/AArch64/Rndr.c @@ -50,7 +50,6 @@ BaseRngLibConstructor ( // MSR. A non-zero value indicates that the processor supports the RNDR instruction. // Isar0 = ArmReadIdIsar0 (); - ASSERT ((Isar0 & RNDR_MASK) != 0); mRndrSupported = ((Isar0 & RNDR_MASK) != 0); -- cgit v1.2.3