From 70b174e24db4a6de1590fda65846074dcb9fd7d3 Mon Sep 17 00:00:00 2001 From: Abner Chang Date: Tue, 28 Nov 2023 21:14:19 +0800 Subject: RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port BZ #4607 Create a PCD for the default Redfish service port. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin Reviewed-by: Nickle Wang --- .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- .../PlatformHostInterfaceBmcUsbNicLib.inf | 1 + RedfishPkg/RedfishPkg.dec | 8 ++++++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c index 9590057911..fc68125a08 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c @@ -244,7 +244,7 @@ RedfishPlatformHostInterfaceProtocolData ( ); // RedfishServiceIpPort - RedfishOverIpData->RedfishServiceIpPort = 0; + RedfishOverIpData->RedfishServiceIpPort = PcdGet16 (PcdRedfishServicePort); // RedfishServiceVlanId RedfishOverIpData->RedfishServiceVlanId = ThisInstance->VLanId; diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf index f2c7d7fec8..838a1721a7 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf @@ -43,6 +43,7 @@ [Pcd] gEfiRedfishPkgTokenSpaceGuid.PcdRedfishHostName ## CONSUMED gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid ## CONSUMED + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort ## CONSUMED [Depex] gIpmiProtocolGuid diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index 0f18865cea..077f1e824a 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -138,12 +138,16 @@ # specification for that. # gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid|L"00000000-0000-0000-0000-000000000000"|VOID*|0x00001006 + # Use PCD to declare the Redfish service port, default set to port 443. + # Platform can overide this value in platform DSC file. + # + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort|443|UINT16|0x00001007 # # This PCD indicates that if BMC bootstrap credential service will be disabled by BIOS or not. # - gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|FALSE|BOOLEAN|0x00001007 + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|FALSE|BOOLEAN|0x00001008 # # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that RedfishDiscoverDxe driver # set to EFI_REST_EX_PROTOCOL. # - gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x00001008 + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x00001009 -- cgit v1.2.3