From 7742a8dd23ec6366a9741d8ff9ab042ca8b21c62 Mon Sep 17 00:00:00 2001 From: Dandan Bi Date: Wed, 7 Feb 2018 09:00:17 +0800 Subject: MdeModulePkg/PciBusDxe: Fix VS2012 build failure Initialize local variable to suppress warning C4703: potentially uninitialized local pointer variable. Both reads (dereferences) of "PciRootBridgeIo" in PciBusDriverBindingStart() are only reached if "gFullEnumeration" is TRUE on entry *and* we successfully open the EfiPciRootBridgeIoProtocol interface. Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi Reviewed-by: Ruiyu Ni Reviewed-by: Star Zeng Reviewed-by: Laszlo Ersek (cherry picked from commit a012bf6e3e08d1fc878ffb271932e3cbce4a71f6) --- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c index c48e3bba96..a1654c0025 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c @@ -244,6 +244,11 @@ PciBusDriverBindingStart ( EFI_DEVICE_PATH_PROTOCOL *ParentDevicePath; EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL *PciRootBridgeIo; + // + // Initialize PciRootBridgeIo to suppress incorrect compiler warning. + // + PciRootBridgeIo = NULL; + // // Check RemainingDevicePath validation // -- cgit v1.2.3