From 7935be0fbd8f47266e5972f4cba1a1e58505061a Mon Sep 17 00:00:00 2001 From: Chasel Chiu Date: Tue, 28 Dec 2021 16:58:04 +0800 Subject: IntelFsp2Pkg/FspSecCore: ExtendedImageRevision was not printed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3791 ExtendedImageRevision should be printed when Header revision >= 6. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Reviewed-by: Star Zeng --- IntelFsp2Pkg/FspSecCore/SecFsp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.c b/IntelFsp2Pkg/FspSecCore/SecFsp.c index ae03fa228e..f79d45900e 100644 --- a/IntelFsp2Pkg/FspSecCore/SecFsp.c +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -199,8 +199,12 @@ FspGlobalDataInit ( ImageId, \ (PeiFspData->FspInfoHeader->ImageRevision >> 24) & 0xFF, \ (PeiFspData->FspInfoHeader->ImageRevision >> 16) & 0xFF, \ - (PeiFspData->FspInfoHeader->ImageRevision >> 8) & 0xFF, \ - PeiFspData->FspInfoHeader->ImageRevision & 0xFF + (PeiFspData->FspInfoHeader->HeaderRevision >= 6) ? \ + (((PeiFspData->FspInfoHeader->ImageRevision >> 8) & 0xFF) | (PeiFspData->FspInfoHeader->ExtendedImageRevision & 0xFF00)) :\ + ((PeiFspData->FspInfoHeader->ImageRevision >> 8) & 0xFF), \ + (PeiFspData->FspInfoHeader->HeaderRevision >= 6) ? \ + ((PeiFspData->FspInfoHeader->ImageRevision & 0xFF) | ((PeiFspData->FspInfoHeader->ExtendedImageRevision & 0xFF) << 8)): \ + (PeiFspData->FspInfoHeader->ImageRevision & 0xFF) )); } -- cgit v1.2.3