From 814470b8340725095ad4db48b291b4e2b4e86941 Mon Sep 17 00:00:00 2001 From: Nickle Wang Date: Thu, 11 Jul 2024 15:41:47 +0800 Subject: NetworkPkg/SnpDxe: return error for unsupported parameter REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4729 From SCT testing report, Reset() does not support the case when ExtendedVerification is set to FALSE. So, we should return EFI_INVALID_PARAMETER in this case. For details, please refer to Bug 4729. Signed-off-by: Nickle Wang --- NetworkPkg/SnpDxe/Reset.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/NetworkPkg/SnpDxe/Reset.c b/NetworkPkg/SnpDxe/Reset.c index 2ff685376d..72f31425d0 100644 --- a/NetworkPkg/SnpDxe/Reset.c +++ b/NetworkPkg/SnpDxe/Reset.c @@ -2,6 +2,7 @@ Implementation of resetting a network adapter. Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
+SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -93,10 +94,12 @@ SnpUndi32Reset ( EFI_STATUS Status; // - // Resolve Warning 4 unreferenced parameter problem + // There is no support when ExtendedVerification is set to FALSE. // - ExtendedVerification = 0; - DEBUG ((DEBUG_WARN, "ExtendedVerification = %d is not implemented!\n", ExtendedVerification)); + if (!ExtendedVerification) { + DEBUG ((DEBUG_WARN, "ExtendedVerification = %d is not implemented!\n", ExtendedVerification)); + return EFI_INVALID_PARAMETER; + } if (This == NULL) { return EFI_INVALID_PARAMETER; -- cgit v1.2.3