From c5c5c980dbaadf32193ac5e4ed2a35b665e0c76e Mon Sep 17 00:00:00 2001 From: kuqin Date: Thu, 19 Mar 2020 15:36:56 -0700 Subject: UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609 SavedState is not sticky, copied pointer update will not change source pointer Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Guomin Jiang Reviewed-by: Bret Barkelew --- UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c index b136992d99..ba4b18568d 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c @@ -209,7 +209,6 @@ InitUnitTestFramework ( EFI_STATUS Status; UNIT_TEST_FRAMEWORK_HANDLE NewFrameworkHandle; UNIT_TEST_FRAMEWORK *NewFramework; - UNIT_TEST_SAVE_HEADER *SavedState; Status = EFI_SUCCESS; NewFramework = NULL; @@ -264,8 +263,7 @@ InitUnitTestFramework ( // If there is a persisted context, load it now. // if (DoesCacheExist (NewFrameworkHandle)) { - SavedState = (UNIT_TEST_SAVE_HEADER *)NewFramework->SavedState; - Status = LoadUnitTestCache (NewFrameworkHandle, &SavedState); + Status = LoadUnitTestCache (NewFrameworkHandle, (UNIT_TEST_SAVE_HEADER**)(&NewFramework->SavedState)); if (EFI_ERROR (Status)) { // // Don't actually report it as an error, but emit a warning. -- cgit v1.2.3