From cdd20638bc97cef1356a5c687a412f869c637245 Mon Sep 17 00:00:00 2001 From: Oliver Smith-Denny Date: Fri, 2 Jun 2023 13:23:52 -0700 Subject: CharEncodingCheckPlugin: Remove Noisy Print Currently, CharEncodingCheckPlugin prints a message for every file that passes the test, which for some platforms can cause most of the CI build log to be filled with this print. It does not add any value, so this patch removes the noisy print and only prints if the encoding check fails. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Michael D Kinney Reviewed-by: Michael Kubacki Signed-off-by: Oliver Smith-Denny --- .pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py index b09fb17040..07d9e9ce22 100644 --- a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py +++ b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py @@ -93,9 +93,7 @@ class CharEncodingCheck(ICiBuildPlugin): files = [Edk2pathObj.GetAbsolutePathOnThisSystemFromEdk2RelativePath(x) for x in files] for a in files: files_tested += 1 - if(self.TestEncodingOk(a, enc)): - logging.debug("File {0} Passed Encoding Check {1}".format(a, enc)) - else: + if not self.TestEncodingOk(a, enc): tc.LogStdError("Encoding Failure in {0}. Not {1}".format(a, enc)) overall_status += 1 -- cgit v1.2.3