From f297b7f20010711e36e981fe45645302cc9d109d Mon Sep 17 00:00:00 2001
From: Getnat Ejigu <getnatejigu@gmail.com>
Date: Fri, 30 Apr 2021 14:07:49 -0700
Subject: UnitTestFrameworkPkg: Sample unit test hangs when running in
 OVMF/QEMU

Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.

Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c                        | 1 +
 .../Library/UnitTestResultReportLib/UnitTestResultReportLib.c            | 1 +
 .../Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c      | 1 +
 .../Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c    | 1 +
 4 files changed, 4 insertions(+)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
index 3669d63701..9a74016456 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
@@ -42,6 +42,7 @@ AddUnitTestFailure (
 
 STATIC
 VOID
+EFIAPI
 UnitTestLogFailure (
   IN FAILURE_TYPE  FailureType,
   IN CONST CHAR8   *Format,
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d..7f7443a233 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
 #include <Library/DebugLib.h>
 
 VOID
+EFIAPI
 ReportPrint (
   IN CONST CHAR8  *Format,
   ...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972b..db5402d6a2 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
 #include <Library/DebugLib.h>
 
 VOID
+EFIAPI
 ReportPrint (
   IN CONST CHAR8  *Format,
   ...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83..1d62c6a371 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
 #include <Library/DebugLib.h>
 
 VOID
+EFIAPI
 ReportPrint (
   IN CONST CHAR8  *Format,
   ...
-- 
cgit v1.2.3