From f662f91cb2c8f109816c24d91957f4d254245633 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Fri, 13 Sep 2019 00:29:43 +0200 Subject: MdeModulePkg/PiSmmCore: make type punning consistent The SmiHandlerRegister() function explicitly casts "SmiHandler" (of type (SMI_HANDLER*)) to EFI_HANDLE, when outputting "DispatchHandle". Apply the same cast in the counterpart function SmiHandlerUnRegister(), which compares multiple "SmiHandler"s against the input "DispatchHandle". This is a semantic cleanup; there is no functional change. Cc: Eric Dong Cc: Hao A Wu Cc: Jian J Wang Cc: Ray Ni Signed-off-by: Laszlo Ersek Reviewed-by: Eric Dong Reviewed-by: Hao A Wu --- MdeModulePkg/Core/PiSmmCore/Smi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c b/MdeModulePkg/Core/PiSmmCore/Smi.c index f8bd9f49ee..488af6754f 100644 --- a/MdeModulePkg/Core/PiSmmCore/Smi.c +++ b/MdeModulePkg/Core/PiSmmCore/Smi.c @@ -282,7 +282,7 @@ SmiHandlerUnRegister ( // SmiHandler = NULL; for ( HandlerLink = GetFirstNode (&mRootSmiEntry.SmiHandlers) - ; !IsNull (&mRootSmiEntry.SmiHandlers, HandlerLink) && (SmiHandler != DispatchHandle) + ; !IsNull (&mRootSmiEntry.SmiHandlers, HandlerLink) && ((EFI_HANDLE) SmiHandler != DispatchHandle) ; HandlerLink = GetNextNode (&mRootSmiEntry.SmiHandlers, HandlerLink) ) { SmiHandler = CR (HandlerLink, SMI_HANDLER, Link, SMI_HANDLER_SIGNATURE); @@ -292,19 +292,19 @@ SmiHandlerUnRegister ( // Look for it in non-root SMI handlers // for ( EntryLink = GetFirstNode (&mSmiEntryList) - ; !IsNull (&mSmiEntryList, EntryLink) && (SmiHandler != DispatchHandle) + ; !IsNull (&mSmiEntryList, EntryLink) && ((EFI_HANDLE) SmiHandler != DispatchHandle) ; EntryLink = GetNextNode (&mSmiEntryList, EntryLink) ) { SmiEntry = CR (EntryLink, SMI_ENTRY, AllEntries, SMI_ENTRY_SIGNATURE); for ( HandlerLink = GetFirstNode (&SmiEntry->SmiHandlers) - ; !IsNull (&SmiEntry->SmiHandlers, HandlerLink) && (SmiHandler != DispatchHandle) + ; !IsNull (&SmiEntry->SmiHandlers, HandlerLink) && ((EFI_HANDLE) SmiHandler != DispatchHandle) ; HandlerLink = GetNextNode (&SmiEntry->SmiHandlers, HandlerLink) ) { SmiHandler = CR (HandlerLink, SMI_HANDLER, Link, SMI_HANDLER_SIGNATURE); } } - if (SmiHandler != DispatchHandle) { + if ((EFI_HANDLE) SmiHandler != DispatchHandle) { return EFI_INVALID_PARAMETER; } -- cgit v1.2.3