From f9ebccec096742465c0dfbbbb123d2c39f554d40 Mon Sep 17 00:00:00 2001 From: Ard Biesheuvel Date: Fri, 1 Jul 2016 12:29:37 +0200 Subject: ArmPkg/DefaultExceptionHandlerLib: put ASSERT (FALSE) last Putting DEBUG () code after an ASSERT (FALSE) statement is not very useful, since the code will be unreachable on DEBUG builds and compiled out on RELEASE builds. So move the ASSERT () statement after it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Acked-by: Mark Rutland Reviewed-by: Leif Lindholm --- .../DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ArmPkg') diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c index 45a166ad21..31fc936b21 100644 --- a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c @@ -191,7 +191,6 @@ DefaultExceptionHandler ( DEBUG ((EFI_D_ERROR, "\n ESR : EC 0x%02x IL 0x%x ISS 0x%08x\n", (SystemContext.SystemContextAArch64->ESR & 0xFC000000) >> 26, (SystemContext.SystemContextAArch64->ESR >> 25) & 0x1, SystemContext.SystemContextAArch64->ESR & 0x1FFFFFF )); DescribeExceptionSyndrome (SystemContext.SystemContextAArch64->ESR); - ASSERT (FALSE); DEBUG ((EFI_D_ERROR, "\nStack dump:\n")); for (Offset = -256; Offset < 256; Offset += 32) { @@ -204,5 +203,6 @@ DefaultExceptionHandler ( *(UINT64 *)(SystemContext.SystemContextAArch64->SP + Offset + 24))); } + ASSERT (FALSE); CpuDeadLoop (); } -- cgit v1.2.3