From b2282e5369c10a26e8cbf125cc22032ba903d619 Mon Sep 17 00:00:00 2001 From: Yonghong Zhu Date: Fri, 10 Aug 2018 14:47:35 +0800 Subject: BaseTools: Remove the redundant if statement after analysis the BuildOptionValue function, we found the if statement IsFieldValueAnArray is redundant because ValueExpressionEx will handle it. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Reviewed-by: Liming Gao --- BaseTools/Source/Python/Common/Expression.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'BaseTools/Source/Python/Common/Expression.py') diff --git a/BaseTools/Source/Python/Common/Expression.py b/BaseTools/Source/Python/Common/Expression.py index ccc736846a..0091e471c0 100644 --- a/BaseTools/Source/Python/Common/Expression.py +++ b/BaseTools/Source/Python/Common/Expression.py @@ -17,7 +17,7 @@ from __future__ import absolute_import from Common.GlobalData import * from CommonDataClass.Exceptions import BadExpression from CommonDataClass.Exceptions import WrnExpression -from .Misc import GuidStringToGuidStructureString, ParseFieldValue, IsFieldValueAnArray +from .Misc import GuidStringToGuidStructureString, ParseFieldValue import Common.EdkLogger as EdkLogger import copy from Common.DataType import * @@ -138,11 +138,11 @@ def BuildOptionValue(PcdValue, GuidDict): InputValue = 'L"' + PcdValue[1:] + '"' else: InputValue = PcdValue - if IsFieldValueAnArray(InputValue): - try: - PcdValue = ValueExpressionEx(InputValue, TAB_VOID, GuidDict)(True) - except: - pass + try: + PcdValue = ValueExpressionEx(InputValue, TAB_VOID, GuidDict)(True) + except: + pass + return PcdValue ## ReplaceExprMacro -- cgit v1.2.3