From 9e47e6f90880e090cd81f585abd7a6c553fbce10 Mon Sep 17 00:00:00 2001 From: "Carsey, Jaben" Date: Wed, 24 Oct 2018 01:29:19 +0800 Subject: BaseTools/GenFds: cleanup GenFds 1) remove wildcard imports and use explicit imports 2) refactor to use shared variables from Common/DataType 3) rename to not shadow imports 4) don't assign a variable in a loop (just do final assignment) 5) remove spaces, parens, unused or commented out code, etc. 6) merge unnecessary parent classes into child 7) refactor to share DXE and PEI apriori GUIDs from one place this includes changes to Build and EOT files 8) for PEP8, dont use __ for custom methods. Cc: Yonghong Zhu Cc: Liming Gao Cc: Bob C Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey Reviewed-by: Yonghong Zhu --- BaseTools/Source/Python/GenFds/Region.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'BaseTools/Source/Python/GenFds/Region.py') diff --git a/BaseTools/Source/Python/GenFds/Region.py b/BaseTools/Source/Python/GenFds/Region.py index 5242b74c9e..9aeaa45d45 100644 --- a/BaseTools/Source/Python/GenFds/Region.py +++ b/BaseTools/Source/Python/GenFds/Region.py @@ -20,7 +20,6 @@ from struct import * from .GenFdsGlobalVariable import GenFdsGlobalVariable from io import BytesIO import string -from CommonDataClass.FdfClass import RegionClassObject import Common.LongFilePathOs as os from stat import * from Common import EdkLogger @@ -32,15 +31,20 @@ from Common.DataType import BINARY_FILE_TYPE_FV ## generate Region # # -class Region(RegionClassObject): +class Region(object): ## The constructor # # @param self The object pointer # def __init__(self): - RegionClassObject.__init__(self) - + self.Offset = None # The begin position of the Region + self.Size = None # The Size of the Region + self.PcdOffset = None + self.PcdSize = None + self.SetVarDict = {} + self.RegionType = None + self.RegionDataList = [] ## PadBuffer() # -- cgit v1.2.3