From 4e375707392e4f9085e2d2342e41aee9d4df2b0a Mon Sep 17 00:00:00 2001 From: BobCF Date: Thu, 8 Nov 2018 18:16:25 +0800 Subject: BaseTools: Optimize string concatenation https://bugzilla.tianocore.org/show_bug.cgi?id=1288 This patch is one of build tool performance improvement series patches. This patch is going to use join function instead of string += string2 statement. Current code use string += string2 in a loop to combine a string. while creating a string list in a loop and using "".join(stringlist) after the loop will be much faster. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: BobCF Cc: Liming Gao Cc: Jaben Carsey Reviewed-by: Liming Gao Reviewed-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/InfBuildData.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'BaseTools/Source/Python/Workspace/InfBuildData.py') diff --git a/BaseTools/Source/Python/Workspace/InfBuildData.py b/BaseTools/Source/Python/Workspace/InfBuildData.py index d10cfea40d..99bbecfd1f 100644 --- a/BaseTools/Source/Python/Workspace/InfBuildData.py +++ b/BaseTools/Source/Python/Workspace/InfBuildData.py @@ -614,7 +614,9 @@ class InfBuildData(ModuleBuildClassObject): Instance = Record[1] if Instance: Instance = NormPath(Instance, self._Macros) - RetVal[Lib] = Instance + RetVal[Lib] = Instance + else: + RetVal[Lib] = None return RetVal ## Retrieve library names (for Edk.x style of modules) -- cgit v1.2.3