From 5d7a1d63c0fa53d411a06c6f03de939c1cc26da2 Mon Sep 17 00:00:00 2001 From: Qin Long Date: Sat, 1 Apr 2017 11:30:55 +0800 Subject: CryptoPkg: Fix possible unresolved external symbol issue. The compiler (visual studio) may optimize some explicit strcmp call in openssl source to use the intrinsic memcmp call. In CrtLibSupport.h, we just use #define to mapping memcmp to CompareMem API. So in Link phase, this kind of intrinsic optimization will cause the "unresolved external symbol" error. For example: OpensslLib.lib(v3_utl.obj) : error LNK2001: unresolved external symbol _memcmp This patch will keep the memcmp mapping, and provide extra Intrinsic memcmp wrapper to satisfy the symbol link. Cc: Ting Ye Cc: Feng Tian Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long Reviewed-by: Laszlo Ersek --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) (limited to 'CryptoPkg/Library/Include') diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index ddf7784a37..7f1ec12302 100644 --- a/CryptoPkg/Library/Include/CrtLibSupport.h +++ b/CryptoPkg/Library/Include/CrtLibSupport.h @@ -133,6 +133,7 @@ void *malloc (size_t); void *realloc (void *, size_t); void free (void *); void *memset (void *, int, size_t); +int memcmp (const void *, const void *, size_t); int isdigit (int); int isspace (int); int isxdigit (int); -- cgit v1.2.3