From dd7523b5b123de6f0730f2f2abb207f2a5c1ccd4 Mon Sep 17 00:00:00 2001 From: Sami Mujawar Date: Mon, 18 Nov 2019 16:37:30 +0000 Subject: DynamicTablesPkg: SRAT: Fix uninitialized memory usage On enabling the /analyse option the VS2017 compiler reports: warning C6001: Using uninitialized memory. This warning is reported for the Status variable in AddGenericInitiatorAffinity() as it is not initialised to a default value. This condition is only valid if GenInitAffCount is equal to 0. Since GenInitAffCount is already checked in BuildSratTable() this condition can never happen. The value of the Status variable is returned in failure cases from appropriate locations in AddGenericInitiatorAffinity(). The only case where Status value is being used un-initialised is the return statement at the end of AddGenericInitiatorAffinity(). Therefore, to fix this issue EFI_SUCCESS can be safely returned instead of returning the Status variable at the end of the function. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'DynamicTablesPkg') diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c index 74cb7d92a5..620e2929ef 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c @@ -413,7 +413,7 @@ AddGenericInitiatorAffinity ( GenInitAff++; GenInitAffInfo++; }// while - return Status; + return EFI_SUCCESS; } /** Construct the SRAT ACPI table. -- cgit v1.2.3