From 7b6ceb4d3b4678a9e76a3ff881b25d5e68c4439c Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Sat, 7 Sep 2019 01:25:10 +0200 Subject: EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: IN OUT EFI_HANDLE *ChildHandle - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: IN EFI_HANDLE ChildHandle Fix the DestroyChild() call in TcpFastbootTransportStop(). This is an actual bugfix; I don't know why the current code doesn't crash. Perhaps the function is never reached in practice? (It could be tied to an error path.) Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude Acked-by: Ard Biesheuvel --- .../Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'EmbeddedPkg') diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c index 29f23a82c7..34f9ba74e4 100644 --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( Status = mTcpListener->Configure (mTcpListener, NULL); ASSERT_EFI_ERROR (Status); - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, &mTcpHandle); + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); // Free any data the user didn't pick up Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (&mPacketListHead); -- cgit v1.2.3