From 66ea28dffde8520e0af8845682f93a93811cf706 Mon Sep 17 00:00:00 2001 From: jchen20 Date: Wed, 8 Jul 2009 09:49:07 +0000 Subject: to describe the gap between Framework spec and code to fix the bug #202434 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8820 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFrameworkPkg/Include/Protocol/IdeControllerInit.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'IntelFrameworkPkg/Include') diff --git a/IntelFrameworkPkg/Include/Protocol/IdeControllerInit.h b/IntelFrameworkPkg/Include/Protocol/IdeControllerInit.h index 8b23693d76..7ea1f6bd00 100644 --- a/IntelFrameworkPkg/Include/Protocol/IdeControllerInit.h +++ b/IntelFrameworkPkg/Include/Protocol/IdeControllerInit.h @@ -355,8 +355,12 @@ EFI_STATUS @retval EFI_SUCCESS The modes were accepted without any errors. @retval EFI_INVALID_PARAMETER Channel is invalid (Channel >= ChannelCount). - Or Device is invalid, - Or IdentifyData is NULL. + Or Device is invalid. + + @note: Inconsistent with specification here: + Framework Spec IdeCont defined another case to return EFI_INVALID_PARAMETER when + IdentifyData is NULL. However in the function there is no parameter named IdentifyData. + So that should be a typo error in spec. **/ typedef -- cgit v1.2.3