From 901ae29dfef82186b8a54d29738fbe18add18764 Mon Sep 17 00:00:00 2001 From: "Chasel, Chiu" Date: Fri, 26 Oct 2018 10:41:49 +0800 Subject: IntelFsp2Pkg: Fix GCC49/XCODE build failure REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1276 Fixed potentially uninitialized variable build failure caused by commit: b1cc6f672f3b924cdb190e5b92db3b47f46a8911 Test: Verified on internal platform and boots successfully. Cc: Jiewen Yao Cc: Desimone Nathaniel L Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chasel Chiu Reviewed-by: Jiewen Yao --- IntelFsp2Pkg/FspSecCore/SecMain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'IntelFsp2Pkg') diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.c b/IntelFsp2Pkg/FspSecCore/SecMain.c index ddbfc4fcdf..f319c68cc5 100644 --- a/IntelFsp2Pkg/FspSecCore/SecMain.c +++ b/IntelFsp2Pkg/FspSecCore/SecMain.c @@ -107,13 +107,12 @@ SecStartup ( } IdtSize = sizeof (IdtTableInStack.IdtTable); } else { - if (IdtDescriptor.Limit + 1 > sizeof (IdtTableInStack.IdtTable)) { + IdtSize = IdtDescriptor.Limit + 1; + if (IdtSize > sizeof (IdtTableInStack.IdtTable)) { // // ERROR: IDT table size from boot loader is larger than FSP can support, DeadLoop here! // CpuDeadLoop(); - } else { - IdtSize = IdtDescriptor.Limit + 1; } CopyMem ((VOID *) (UINTN) &IdtTableInStack.IdtTable, (VOID *) IdtDescriptor.Base, IdtSize); } -- cgit v1.2.3