From b585238d33855fa1ad2ddf83d3fd38d7d48824a1 Mon Sep 17 00:00:00 2001 From: Samer El-Haj-Mahmoud Date: Sun, 20 Dec 2020 21:53:53 +0800 Subject: MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE REF: https://github.com/pftf/RPi4/issues/115 GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. However, the driver never draws the cursor during init. This results in the first call to disable the cursor (using ConOut->EnableCursor(FALSE)) to actually draw the cursor on the screen, as the logic in FlushCursor depends on the Mode.CursorVisible state to determine if it should draw or erase the cursor. Fix by changing the default CursorVisible in this driver to FALSE. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao Reviewed-by: Pete Batard Tested-by: Pete Batard (On an RPi4 platform where we had this annoyance of an unwanted cursor displaying on top of the platform logo) --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'MdeModulePkg') diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index c042451a9b..6b8d11d587 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate = { EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK), 0, 0, - TRUE + FALSE }, (GRAPHICS_CONSOLE_MODE_DATA *) NULL, (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL -- cgit v1.2.3