From ef35863880ab7728e69c690603afb77182cb14ea Mon Sep 17 00:00:00 2001 From: Jessica Clarke Date: Wed, 6 Nov 2024 21:26:01 +0000 Subject: ArmPlatformPkg,MdePkg: Rename AARCH64 CPACR_CP_FULL_ACCESS CP_FULL_ACCESS is a misnomer, we only enable access to SIMD/FP state, and although the register's mnemonic is CPACR_EL1, its full name is "Architectural Feature Access Control Register", with AArch64 having no coprocessors like AArch32 did, so the "CP" is also not appropriate. Rename it to show it's the default value we use on entry, and define it in terms of the existing CPACR_FPEN_FULL rather than a magic constant with the same value to more clearly document that fact. Also update comments to reflect all this (including the CPTR_EL2 case). Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Jessica Clarke --- MdePkg/Include/AArch64/AArch64.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'MdePkg') diff --git a/MdePkg/Include/AArch64/AArch64.h b/MdePkg/Include/AArch64/AArch64.h index c1a24c1e30..3186bfb548 100644 --- a/MdePkg/Include/AArch64/AArch64.h +++ b/MdePkg/Include/AArch64/AArch64.h @@ -16,10 +16,10 @@ #define ARM_ARCH_EXCEPTION_IRQ EXCEPT_AARCH64_IRQ // CPACR - Coprocessor Access Control Register definitions -#define CPACR_TTA_EN (1UL << 28) -#define CPACR_FPEN_EL1 (1UL << 20) -#define CPACR_FPEN_FULL (3UL << 20) -#define CPACR_CP_FULL_ACCESS 0x300000 +#define CPACR_TTA_EN (1UL << 28) +#define CPACR_FPEN_EL1 (1UL << 20) +#define CPACR_FPEN_FULL (3UL << 20) +#define CPACR_DEFAULT CPACR_FPEN_FULL // Coprocessor Trap Register (CPTR) #define AARCH64_CPTR_TFP (1 << 10) -- cgit v1.2.3