From 7be6e6776253d3638f03375e346e978228af5edb Mon Sep 17 00:00:00 2001 From: Gary Lin Date: Mon, 16 Jan 2017 14:30:10 +0800 Subject: NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the ChooseFile handler The ChooseFile handler, UpdateCAFromFile, has to be EFIAPI or gcc would use the wrong ABI and cause the crash of the firmware. This commit also removes the unnecessary type casting in ChooseFile. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin Reviewed-by: Siyuan Fu Reviewed-by: Jiaxin Wu --- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'NetworkPkg/TlsAuthConfigDxe') diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c index 5f04503887..4603645461 100644 --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c @@ -1218,6 +1218,7 @@ UpdatePage( @retval FALSE Not exit caller function. **/ BOOLEAN +EFIAPI UpdateCAFromFile ( IN EFI_DEVICE_PATH_PROTOCOL *FilePath ) @@ -1728,7 +1729,7 @@ TlsAuthConfigAccessCallback ( CleanUpPage (LabelId, Private); break; case KEY_TLS_AUTH_CONFIG_ENROLL_CERT_FROM_FILE: - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateCAFromFile, &File); + ChooseFile( NULL, NULL, UpdateCAFromFile, &File); break; case KEY_TLS_AUTH_CONFIG_VALUE_SAVE_AND_EXIT: -- cgit v1.2.3