From b94836b2241c16c74d70d7bb2ae478f7750655bc Mon Sep 17 00:00:00 2001 From: Dimitrije Pavlov Date: Tue, 16 Aug 2022 15:28:36 -0500 Subject: OvmfPkg/VirtioGpuDxe: Check QueryMode arguments The current implementation does not check if Info or SizeInfo pointers are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioGpuDxe/Gop.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'OvmfPkg/VirtioGpuDxe') diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c index 401db47672..16e92830d4 100644 --- a/OvmfPkg/VirtioGpuDxe/Gop.c +++ b/OvmfPkg/VirtioGpuDxe/Gop.c @@ -308,7 +308,10 @@ GopQueryMode ( { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *GopModeInfo; - if (ModeNumber >= This->Mode->MaxMode) { + if ((Info == NULL) || + (SizeOfInfo == NULL) || + (ModeNumber >= This->Mode->MaxMode)) + { return EFI_INVALID_PARAMETER; } -- cgit v1.2.3