From b4f8c75e316e74750d5806b8ebf2bd11a3d62626 Mon Sep 17 00:00:00 2001 From: Mike Maslenkin Date: Mon, 6 Nov 2023 05:15:07 +0300 Subject: RedfishPkg: add explicit variable initialization Ancient GCC 4.8.5 warned about variable may be unitialied. And it doesn't look like false alarm. The warning is: edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function 'GetQuestionDefault': edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: 'ConfigAccess' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (ConfigAccess != NULL) { Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 + 1 file changed, 1 insertion(+) (limited to 'RedfishPkg') diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c index 80b93beae9..b61b7f5fcd 100644 --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c @@ -5451,6 +5451,7 @@ GetQuestionDefault ( Status = EFI_NOT_FOUND; StrValue = NULL; + ConfigAccess = NULL; OriginalDefaultId = DefaultId; DefaultLink = GetFirstNode (&FormSet->DefaultStoreListHead); -- cgit v1.2.3