From c00ad62378b1594c9af0f9ebbcc2e30d05a2121e Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Fri, 1 Sep 2017 09:32:10 +0800 Subject: SourceLevelDebugPkg: Use Pcd for the revision of transfer protocol V3 changes: Add detailed description for the usage of the Pcd in package DEC file. Update the comment for the introduced Pcd in module INF files. V2 changes: Instead of using a global variable, use a Pcd for transfer protocol revision. Previously, the revision of the debug agent transfer protocol is reflected by a macro. This commit introduces a Pcd to reflect the revision in order to avoid the comparison of two macros, which will generate a constant result detected by code checkers. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu Reviewed-by: Ruiyu Ni --- SourceLevelDebugPkg/SourceLevelDebugPkg.uni | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'SourceLevelDebugPkg/SourceLevelDebugPkg.uni') diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.uni b/SourceLevelDebugPkg/SourceLevelDebugPkg.uni index 533dafbfc8..781b717e4e 100644 --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.uni +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.uni @@ -8,7 +8,7 @@ // and host, PeCoffExtraActionLib instance to report symbol path information, // etc. // -// Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+// Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
// // This program and the accompanying materials are licensed and made available under // the terms and conditions of the BSD License that accompanies this distribution. @@ -91,3 +91,10 @@ #string STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdUsbXhciDebugDetectTimeout_HELP #language en-US "Per XHCI spec, software shall impose a timeout between the detection of the Debug Host\n" "connection and the DbC Run transition to 1. This PCD specifies the timeout value in microsecond." +#string STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdTransferProtocolRevision_PROMPT #language en-US "Default revision of the debug agent transfer protocol." + +#string STR_gEfiSourceLevelDebugPkgTokenSpaceGuid_PcdTransferProtocolRevision_HELP #language en-US "The upper 16 bits indicate the major revision and the lower 16 bits indicate\n" + "the minor revision.\n" + "For example, a value of 0x00000004 stands for revision 0.4.\n" + "Debug packet compression and decompression is supported since revision 0.4." + -- cgit v1.2.3