From 3cde0d553d9324a3681b65f9d9a2a8691af26840 Mon Sep 17 00:00:00 2001 From: Ray Ni Date: Tue, 29 Jun 2021 11:07:51 +0800 Subject: UefiPayloadPkg/PayloadLoader: Remove assertion For R_386_RELATIVE and R_X86_64_RELATIVE, today's logic assumes that the content pointed by the Rela->r_offset is 0 but it's not always TRUE. We observed that linker may set the content to Rela->r_addend. The patch removes the assertion. There is no functionality impact for this patch. Signed-off-by: Ray Ni Cc: Maurice Ma Reviewed-by: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c | 1 - UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c | 1 - 2 files changed, 2 deletions(-) (limited to 'UefiPayloadPkg') diff --git a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c index dd27d3ce59..780f2d9507 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c @@ -164,7 +164,6 @@ ProcessRelocation32 ( // Calculation: B + A // if (RelaType == SHT_RELA) { - ASSERT (*Ptr == 0); *Ptr = (UINT32) Delta + Rela->r_addend; } else { // diff --git a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c index 3f4f12903c..0f1b06e8cc 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf64Lib.c @@ -173,7 +173,6 @@ ProcessRelocation64 ( // Calculation: B + A // if (RelaType == SHT_RELA) { - ASSERT (*Ptr == 0); *Ptr = Delta + Rela->r_addend; } else { // -- cgit v1.2.3