summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2022-03-06 00:21:52 +0100
committerNico Huber <nico.h@gmx.de>2022-03-07 16:45:39 +0000
commit2386e94850149aea3f5a7d0962f77b6d74d060ec (patch)
tree0f6f6be450ebf636fe89f8d98e569ea136fbf75d
parentf9b8fece4f5a134d4a32f0b9662c023553fb64fa (diff)
downloadflashrom-2386e94850149aea3f5a7d0962f77b6d74d060ec.tar.gz
flashrom-2386e94850149aea3f5a7d0962f77b6d74d060ec.tar.bz2
flashrom-2386e94850149aea3f5a7d0962f77b6d74d060ec.zip
dmi: Correctly check for ERROR_PTR
For the physmap*() functions, NULL is considered valid return value. Fixes a segmentation fault when DMI tables can't be mapped. Tested on intel/eblake board with broken coreboot. Change-Id: Ic403c2940c2b91acbd113f0acfa3ce9ef6c6bb6c Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62616 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--dmi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/dmi.c b/dmi.c
index 729cdb119..2d17294b1 100644
--- a/dmi.c
+++ b/dmi.c
@@ -169,7 +169,7 @@ static void dmi_table(uint32_t base, uint16_t len, uint16_t num)
int i = 0, j = 0;
uint8_t *dmi_table_mem = physmap_ro("DMI Table", base, len);
- if (dmi_table_mem == NULL) {
+ if (dmi_table_mem == ERROR_PTR) {
msg_perr("Unable to access DMI Table\n");
return;
}