diff options
| author | Jacob Garber <jgarber1@ualberta.ca> | 2019-08-12 10:44:17 -0600 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2022-09-29 17:01:44 +0000 |
| commit | d43c299ca8c4f3985eba6bc6e7266e67b37c25cb (patch) | |
| tree | 314f6e8d5cbea90ff8aeecabd26c769da1b6383e | |
| parent | ee65a0357e6b836920f59a5ab50d97e2e4d4dd0f (diff) | |
| download | flashrom-d43c299ca8c4f3985eba6bc6e7266e67b37c25cb.tar.gz flashrom-d43c299ca8c4f3985eba6bc6e7266e67b37c25cb.tar.bz2 flashrom-d43c299ca8c4f3985eba6bc6e7266e67b37c25cb.zip | |
dummyflasher: Add error check for file read
Print an error message and return if the read from emu_persistent_image
fails.
Change-Id: Icd1a72f9171e547f2081ba4bc53834a17ef7fcab
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1403912
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34845
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67849
Reviewed-by: Felix Singer <felixsinger@posteo.net>
| -rw-r--r-- | dummyflasher.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/dummyflasher.c b/dummyflasher.c index 53801d9cb..3964226e5 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -378,8 +378,12 @@ int dummy_init(void) if (image_stat.st_size == emu_chip_size) { msg_pdbg("matches.\n"); msg_pdbg("Reading %s\n", emu_persistent_image); - read_buf_from_file(flashchip_contents, emu_chip_size, - emu_persistent_image); + if (read_buf_from_file(flashchip_contents, emu_chip_size, + emu_persistent_image)) { + msg_perr("Unable to read %s\n", emu_persistent_image); + free(flashchip_contents); + return 1; + } } else { msg_pdbg("doesn't match.\n"); } |