summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2022-03-06 00:21:52 +0100
committerFelix Singer <felixsinger@posteo.net>2022-09-29 17:06:09 +0000
commit245e540ecbe8e0daa8db747dcc6d470fa6f79938 (patch)
treeb8bfd72696a54c0adb7f3e3d06afaedcf9b36c48
parent04fce478cb9aba339439d1955c3355a075445ec1 (diff)
downloadflashrom-245e540ecbe8e0daa8db747dcc6d470fa6f79938.tar.gz
flashrom-245e540ecbe8e0daa8db747dcc6d470fa6f79938.tar.bz2
flashrom-245e540ecbe8e0daa8db747dcc6d470fa6f79938.zip
dmi: Correctly check for ERROR_PTR
For the physmap*() functions, NULL is considered valid return value. Fixes a segmentation fault when DMI tables can't be mapped. Tested on intel/eblake board with broken coreboot. Change-Id: Ic403c2940c2b91acbd113f0acfa3ce9ef6c6bb6c Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/62611 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67875 Reviewed-by: Felix Singer <felixsinger@posteo.net>
-rw-r--r--dmi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/dmi.c b/dmi.c
index c44221c70..7488d61c7 100644
--- a/dmi.c
+++ b/dmi.c
@@ -164,7 +164,7 @@ static void dmi_table(uint32_t base, uint16_t len, uint16_t num)
unsigned int i = 0, j = 0;
uint8_t *dmi_table_mem = physmap_ro("DMI Table", base, len);
- if (dmi_table_mem == NULL) {
+ if (dmi_table_mem == ERROR_PTR) {
msg_perr("Unable to access DMI Table\n");
return;
}