diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2020-04-23 09:36:12 +0200 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2022-09-29 17:05:00 +0000 |
| commit | 355a1df1837e36075f2b6e59ec1f7db1db95f02a (patch) | |
| tree | c8293d39eff36cc6929242ffe642ba8f4e2a13bb | |
| parent | 399a4dd721a64a1d22e2f8028cc39d6496515ed6 (diff) | |
| download | flashrom-355a1df1837e36075f2b6e59ec1f7db1db95f02a.tar.gz flashrom-355a1df1837e36075f2b6e59ec1f7db1db95f02a.tar.bz2 flashrom-355a1df1837e36075f2b6e59ec1f7db1db95f02a.zip | |
stlinkv3_spi: Avoid division by zero
Change-Id: I08c0612f3fea59add9bde2fb3cc5c4b5c3756516
Found-by: Coverity Scan #1412744
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/40653
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67864
Reviewed-by: Felix Singer <felixsinger@posteo.net>
| -rw-r--r-- | stlinkv3_spi.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c index 733891184..d2988b60e 100644 --- a/stlinkv3_spi.c +++ b/stlinkv3_spi.c @@ -491,10 +491,11 @@ int stlinkv3_spi_init(void) speed_str = extract_programmer_param("spispeed"); if (speed_str) { sck_freq_kHz = strtoul(speed_str, &endptr, 0); - if (*endptr) { + if (*endptr || sck_freq_kHz == 0) { msg_perr("The spispeed parameter passed with invalid format: %s\n", speed_str); - msg_perr("Please pass the parameter with a simple number in kHz\n"); + msg_perr("Please pass the parameter " + "with a simple non-zero number in kHz\n"); return -1; } free(speed_str); |