diff options
| author | Nikolai Artemiev <nartemiev@google.com> | 2022-12-05 13:06:14 +1100 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-12-13 20:49:56 +0000 |
| commit | 53dc84d61447adbb536e0085441c979e171e98c9 (patch) | |
| tree | f939021e22ff51dd9104a42d3886bfb63b339410 | |
| parent | 3b0d05e7a2bca05ba04fd01a7f7a8929f2bcf678 (diff) | |
| download | flashrom-53dc84d61447adbb536e0085441c979e171e98c9.tar.gz flashrom-53dc84d61447adbb536e0085441c979e171e98c9.tar.bz2 flashrom-53dc84d61447adbb536e0085441c979e171e98c9.zip | |
flashchips.c: remove WREN from GD25Q256D enter 4BA sequencev1.3.0-rc1
As noted in a comment on
`commit 86fc9cf7ab221bc54ef6f10252e296fc2d7a22d2`, the GD25Q256D
datasheet indicates that the chip does not require a WREN command to
enter 4BA mode.
Testing has confirmed that a WREN command is not required, so change the
flashchip feature flags from FEATURE_4BA_WREN to FEATURE_4BA.
Ticket: https://ticket.coreboot.org/issues/356
BUG=none
BRANCH=none
TEST=read/write/erase/verify GD25Q256D flash with FT2232H programmer
TEST=called spi_enter_exit_4ba(true), dumped registers, checked ADS=1.
Original-Signed-off-by: Nikolai Artemiev <nartemiev@google.com>
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/70342
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Original-Reviewed-by: Nico Huber <nico.h@gmx.de>
(cherry picked from commit 7f3c3f5c4807f4f3c0c2de405189e86b3f8d77a3)
Change-Id: I96e48933f33c52c0d10a0d4cb7f7e07c1fceab99
Signed-off-by: Evan Benn <evanbenn@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/70323
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | flashchips.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/flashchips.c b/flashchips.c index 76f3fbbfe..9d5b22cc8 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6753,7 +6753,7 @@ const struct flashchip flashchips[] = { .model_id = GIGADEVICE_GD25Q256D, .total_size = 32768, .page_size = 256, - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN | + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_WRSR_EXT2 | FEATURE_WRSR2 | FEATURE_WRSR3, .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, |