diff options
| author | Evan Benn <evanbenn@chromium.org> | 2022-09-13 17:12:59 +1000 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-10-31 22:52:51 +0000 |
| commit | 74c3e56ec24f0d2800ea376d73d9b244cd8a4b40 (patch) | |
| tree | da5aed56e3484445430456f4d6a11b354a7132c6 | |
| parent | b9c03286b668489566c2a4bd17b0861d0e09c38e (diff) | |
| download | flashrom-74c3e56ec24f0d2800ea376d73d9b244cd8a4b40.tar.gz flashrom-74c3e56ec24f0d2800ea376d73d9b244cd8a4b40.tar.bz2 flashrom-74c3e56ec24f0d2800ea376d73d9b244cd8a4b40.zip | |
writeprotect: Add some debug logging if wp_verify fails
Change-Id: I5fcaf767570418f90ae44826a1135d9b49653033
Signed-off-by: Evan Benn <evanbenn@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67720
Reviewed-by: Nikolai Artemiev <nartemiev@google.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | writeprotect.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/writeprotect.c b/writeprotect.c index dcffe0308..f72c362ba 100644 --- a/writeprotect.c +++ b/writeprotect.c @@ -155,6 +155,7 @@ static enum flashrom_wp_result write_wp_bits(struct flashctx *flash, struct wp_b return FLASHROM_WP_ERR_WRITE_FAILED; } + enum flashrom_wp_result ret = FLASHROM_WP_OK; /* Verify each register */ for (enum flash_reg reg = STATUS1; reg < MAX_REGISTERS; reg++) { if (!write_masks[reg]) @@ -164,14 +165,18 @@ static enum flashrom_wp_result write_wp_bits(struct flashctx *flash, struct wp_b if (wp_read_register(flash, reg, &value)) return FLASHROM_WP_ERR_READ_FAILED; + msg_cdbg2("%s: wp_verify reg:%u value:0x%x\n", __func__, reg, value); uint8_t actual = value & write_masks[reg]; uint8_t expected = reg_values[reg] & write_masks[reg]; - if (actual != expected) - return FLASHROM_WP_ERR_VERIFY_FAILED; + if (actual != expected) { + msg_cdbg("%s: wp_verify failed: reg:%u actual:0x%x expected:0x%x\n", + __func__, reg, actual, expected); + ret = FLASHROM_WP_ERR_VERIFY_FAILED; + } } - return FLASHROM_WP_OK; + return ret; } static decode_range_func_t *lookup_decode_range_func_ptr(const struct flashchip *chip) |