diff options
| author | Liam Flaherty <liamflaherty@chromium.org> | 2022-10-13 12:44:40 +1100 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-10-21 05:44:52 +0000 |
| commit | d514c90f9aba4ff24701a06d0a8323e2cb6dde19 (patch) | |
| tree | f36c0e2c72daf50b94c4f124cb40356880b0f45a | |
| parent | 5c69cde56114ec96310a27dca7e72617d15ba2bc (diff) | |
| download | flashrom-d514c90f9aba4ff24701a06d0a8323e2cb6dde19.tar.gz flashrom-d514c90f9aba4ff24701a06d0a8323e2cb6dde19.tar.bz2 flashrom-d514c90f9aba4ff24701a06d0a8323e2cb6dde19.zip | |
raiden_debug_spi: Remove fixme with explanation
The raiden_debug_spi programmer will query the connected USB devices and
match against criteria other than the pid rather than iterate through
the vid:pid table.
The fixme has been updated to explain why the dev_entry table is empty.
TICKET: https://ticket.coreboot.org/issues/394
BUG=b:253320285
TEST=build
Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6
Signed-off-by: Liam Flaherty <liamflaherty@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68364
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
| -rw-r--r-- | raiden_debug_spi.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index fb068c86b..517b17384 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -350,7 +350,11 @@ #include <string.h> #include <unistd.h> -/* FIXME: Add some programmer IDs here */ +/* + * Table is empty as raiden_debug_spi matches against the class and + * subclass of the connected USB devices, rather than looking for a + * device with a specific vid:pid. + */ static const struct dev_entry devs_raiden[] = { {0}, }; |