summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2018-12-23 22:00:47 +0100
committerNico Huber <nico.h@gmx.de>2019-10-05 23:36:34 +0000
commit9e2dc2fc818cc9c1b46924e103ce669ad154b7ab (patch)
tree0aa6df52053c8e7cb9a04614551ce0779c589e3e
parent5374dc3461f1e74a56a4db1a8d684b29cb3a92e5 (diff)
downloadflashrom-9e2dc2fc818cc9c1b46924e103ce669ad154b7ab.tar.gz
flashrom-9e2dc2fc818cc9c1b46924e103ce669ad154b7ab.tar.bz2
flashrom-9e2dc2fc818cc9c1b46924e103ce669ad154b7ab.zip
Makefile,meson.build: Enable/assume -Wextra
Enable all -Wextra warnings but -Wunused-parameter. Nobody seems to miss warnings about unused parameters and we have a lot unavoidable occurrences in flashrom because of common interfaces. Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/30411 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
-rw-r--r--Makefile2
-rw-r--r--meson.build2
2 files changed, 1 insertions, 3 deletions
diff --git a/Makefile b/Makefile
index b0c242d28..f0a1b6198 100644
--- a/Makefile
+++ b/Makefile
@@ -30,7 +30,7 @@ INSTALL = install
DIFF = diff
PREFIX ?= /usr/local
MANDIR ?= $(PREFIX)/share/man
-CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes -Wwrite-strings
+CFLAGS ?= -Os -Wall -Wextra -Wno-unused-parameter -Wshadow -Wmissing-prototypes -Wwrite-strings
EXPORTDIR ?= .
RANLIB ?= ranlib
PKG_CONFIG ?= pkg-config
diff --git a/meson.build b/meson.build
index fda1ab8fa..ca52ccf99 100644
--- a/meson.build
+++ b/meson.build
@@ -15,10 +15,8 @@ lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision)
warning_flags = [
'-Wwrite-strings',
'-Wno-unused-parameter',
- '-Wno-sign-compare',
'-Wno-address-of-packed-member',
'-Wno-enum-conversion',
- '-Wno-missing-field-initializers',
'-Wno-missing-braces',
]