diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-05-25 12:46:43 +0200 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2021-05-28 12:49:17 +0000 |
| commit | 6b1f3b084147a09a90ecb3efea88e3c80113e0ca (patch) | |
| tree | 17c588e359371e08f594ca58ea0a66ecfdfacd81 /dummyflasher.c | |
| parent | 51c1f39e915e24707e5a0632d03816d1e19fae85 (diff) | |
| download | flashrom-6b1f3b084147a09a90ecb3efea88e3c80113e0ca.tar.gz flashrom-6b1f3b084147a09a90ecb3efea88e3c80113e0ca.tar.bz2 flashrom-6b1f3b084147a09a90ecb3efea88e3c80113e0ca.zip | |
dummyflasher.c: Don't leak `emu_persistent_image`
Ensure `emu_persistent_image` doesn't end up leaking memory.
Change-Id: I76529973cefcc6a1472681e1f4da8239fcbf07a6
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54905
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'dummyflasher.c')
| -rw-r--r-- | dummyflasher.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/dummyflasher.c b/dummyflasher.c index 325263dd5..717f8d11f 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -634,9 +634,8 @@ static int dummy_shutdown(void *data) write_buf_to_file(emu_data->flashchip_contents, emu_data->emu_chip_size, emu_data->emu_persistent_image); - free(emu_data->emu_persistent_image); - emu_data->emu_persistent_image = NULL; } + free(emu_data->emu_persistent_image); free(emu_data->flashchip_contents); } #endif @@ -1001,6 +1000,7 @@ int dummy_init(void) if (read_buf_from_file(data->flashchip_contents, data->emu_chip_size, data->emu_persistent_image)) { msg_perr("Unable to read %s\n", data->emu_persistent_image); + free(data->emu_persistent_image); free(data->flashchip_contents); return 1; } @@ -1012,6 +1012,7 @@ int dummy_init(void) dummy_init_out: if (register_shutdown(dummy_shutdown, data)) { + free(data->emu_persistent_image); free(data->flashchip_contents); free(data); return 1; |