summaryrefslogtreecommitdiffstats
path: root/linux_spi.c
diff options
context:
space:
mode:
authorEdward O'Callaghan <quasisec@google.com>2022-09-09 23:14:06 +1000
committerThomas Heijligen <src@posteo.de>2023-03-01 09:43:17 +0000
commit119d0e5236df69702c5ac5be593c4aa683e2b35d (patch)
tree98ee5bafbbdc4bb8346594ba2f49f76de31830c6 /linux_spi.c
parent263d50c7d1f149c5d0f14512a1f6251b2a4e878f (diff)
downloadflashrom-119d0e5236df69702c5ac5be593c4aa683e2b35d.tar.gz
flashrom-119d0e5236df69702c5ac5be593c4aa683e2b35d.tar.bz2
flashrom-119d0e5236df69702c5ac5be593c4aa683e2b35d.zip
spi: Make 'default_spi_send_multicommand' the default unless defined
A NULL func pointer is necessary and sufficient for the condition `NULL func pointer => default_spi_send_multicommand' as to not need this explicit specification of 'default'. Therefore drop the explicit need to specify the 'default_spi_send_multicommand' callback function pointer in the spi_master struct. This is a reasonable default for every other driver in the tree with only a few exceptions. This simplifies the code and driver development. Change-Id: I6cc24bf982da3d5251d391eb397db43dd10280e8 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67481 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Thomas Heijligen <src@posteo.de>
Diffstat (limited to 'linux_spi.c')
-rw-r--r--linux_spi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/linux_spi.c b/linux_spi.c
index d65b3e890..d849fe4b5 100644
--- a/linux_spi.c
+++ b/linux_spi.c
@@ -116,7 +116,6 @@ static const struct spi_master spi_master_linux = {
.max_data_read = MAX_DATA_UNSPECIFIED, /* TODO? */
.max_data_write = MAX_DATA_UNSPECIFIED, /* TODO? */
.command = linux_spi_send_command,
- .multicommand = default_spi_send_multicommand,
.read = linux_spi_read,
.write_256 = linux_spi_write_256,
.shutdown = linux_spi_shutdown,