diff options
| author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-06-15 17:23:36 +0000 |
|---|---|---|
| committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-06-15 17:23:36 +0000 |
| commit | 30f7cb2f3c570c99b61bd5df72621f44f1bdd0d0 (patch) | |
| tree | d714754c298d7d247786e19c4b2b4afd6067a795 /pm49fl00x.c | |
| parent | 084546449983c1d6f147c1a3e381e225887e322c (diff) | |
| download | flashrom-30f7cb2f3c570c99b61bd5df72621f44f1bdd0d0.tar.gz flashrom-30f7cb2f3c570c99b61bd5df72621f44f1bdd0d0.tar.bz2 flashrom-30f7cb2f3c570c99b61bd5df72621f44f1bdd0d0.zip | |
Flashrom only checks for very few chips if the erase worked
And even when it checks if the erase worked, the result of that check is
often ignored.
Convert all erase functions and actually check return codes
almost everywhere.
Check inside all erase_* routines if erase worked, not outside.
erase_sector_jedec and erase_block_jedec have changed prototypes to
enable erase checking.
Uwe successfully tested LPC on an CK804 box and SPI on some SB600 box.
Corresponding to flashrom svn r595.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Urja Rannikko <urjaman@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
Diffstat (limited to 'pm49fl00x.c')
| -rw-r--r-- | pm49fl00x.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/pm49fl00x.c b/pm49fl00x.c index 8129654d8..3b284e6b1 100644 --- a/pm49fl00x.c +++ b/pm49fl00x.c @@ -53,7 +53,6 @@ int erase_49fl00x(struct flashchip *flash) int i; int total_size = flash->total_size * 1024; int page_size = flash->page_size; - chipaddr bios = flash->virtual_memory; /* unprotected */ write_lockbits_49fl00x(flash->virtual_registers, @@ -69,7 +68,10 @@ int erase_49fl00x(struct flashchip *flash) continue; /* erase the page */ - erase_block_jedec(bios, i * page_size); + if (erase_block_jedec(flash, i * page_size, page_size)) { + fprintf(stderr, "ERASE FAILED!\n"); + return -1; + } printf("%04d at address: 0x%08x", i, i * page_size); printf("\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b"); fflush(stdout); @@ -100,7 +102,10 @@ int write_49fl00x(struct flashchip *flash, uint8_t *buf) continue; /* erase the page before programming */ - erase_block_jedec(bios, i * page_size); + if (erase_block_jedec(flash, i * page_size, page_size)) { + fprintf(stderr, "ERASE FAILED!\n"); + return -1; + } /* write to the sector */ printf("%04d at address: 0x%08x", i, i * page_size); |