diff options
author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-12-22 23:54:10 +0000 |
---|---|---|
committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-12-22 23:54:10 +0000 |
commit | db53ec5373db0517c77f91d5d9e447f0771a0243 (patch) | |
tree | ae622763f2f1d79b1c0366f60242d7e13f0a6340 /spi.c | |
parent | 14e100c9335e310b3e84763f29306392574a14f4 (diff) | |
download | flashrom-db53ec5373db0517c77f91d5d9e447f0771a0243.tar.gz flashrom-db53ec5373db0517c77f91d5d9e447f0771a0243.tar.bz2 flashrom-db53ec5373db0517c77f91d5d9e447f0771a0243.zip |
Add a few FIXME comments to the generic SPI code
Corresponding to flashrom svn r814.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Diffstat (limited to 'spi.c')
-rw-r--r-- | spi.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -807,6 +807,7 @@ int spi_write_status_register(int status) int result; struct spi_command cmds[] = { { + /* FIXME: WRSR requires either EWSR or WREN depending on chip type. */ .writecnt = JEDEC_EWSR_OUTSIZE, .writearr = (const unsigned char[]){ JEDEC_EWSR }, .readcnt = 0, @@ -1059,6 +1060,7 @@ int spi_aai_write(struct flashchip *flash, uint8_t *buf) fprintf(stderr, "ERASE FAILED!\n"); return -1; } + /* FIXME: This will fail on ICH/VIA SPI. */ result = spi_write_enable(); if (result) return result; |