From 02350a6fcca8102d9927c6dbc6ce0095ac4051ba Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Wed, 28 Apr 2021 12:05:38 +1000 Subject: mec1308.c: Ensure programmer param variable is always initialised Programmer param variable is now declared inline with the code and is const, so that it cannot be used uninitialised. BUG=b:185191942 TEST=builds and ninja test from 51487 Change-Id: I2d2b3039da2ef185cb31509b3901d56b428688b7 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/52719 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- mec1308.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mec1308.c b/mec1308.c index 0ec9be9de..1530d9b50 100644 --- a/mec1308.c +++ b/mec1308.c @@ -409,9 +409,7 @@ static struct spi_master spi_master_mec1308 = { static int check_params(void) { int ret = 0; - char *p = NULL; - - p = extract_programmer_param("type"); + char *const p = extract_programmer_param("type"); if (p && strcmp(p, "ec")) { msg_pdbg("mec1308 only supports \"ec\" type devices\n"); ret = 1; -- cgit v1.2.3