From 19c6b2821dffe212fba9421495c77fe8f5db319e Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Mon, 5 Jul 2021 16:51:10 +1000 Subject: spi_master: Add default write_aai function to masters that have none write_aai is required to register a spi master, if it is not set in spi_master struct then register_spi_master returns ERROR_FLASHROM_BUG. Masters in this patch did not have it set in the struct, and register_spi_master always returned an error for them. However return value of register_spi_master was ignored, so this was hard to notice. Next patch in the chain checks return value of register_spi_master. BUG=b:185191942 TEST=builds and ninja test Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/56102 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan Reviewed-by: Nico Huber --- ene_lpc.c | 1 + mec1308.c | 1 + 2 files changed, 2 insertions(+) diff --git a/ene_lpc.c b/ene_lpc.c index b30eee699..23ba12be6 100644 --- a/ene_lpc.c +++ b/ene_lpc.c @@ -511,6 +511,7 @@ static const struct spi_master spi_master_ene = { .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, + .write_aai = default_spi_write_aai, }; static int check_params(void) diff --git a/mec1308.c b/mec1308.c index 295bffbc1..c085ff2a3 100644 --- a/mec1308.c +++ b/mec1308.c @@ -404,6 +404,7 @@ static const struct spi_master spi_master_mec1308 = { .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, + .write_aai = default_spi_write_aai, }; static int check_params(void) -- cgit v1.2.3