From 36299dbab2397f25c4009339018065dc79d77452 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Fri, 29 Jul 2022 03:16:19 +0200 Subject: pickit2_spi.c: Use a variable to store the total packetsize Instead of calculating the total packetsize multiple times, use a variable instead. Signed-off-by: Felix Singer Change-Id: I714054669e16dcf531a57174f9522b3af72d2754 Reviewed-on: https://review.coreboot.org/c/flashrom/+/66251 Reviewed-by: Anastasia Klimchuk Reviewed-by: Thomas Heijligen Tested-by: build bot (Jenkins) --- pickit2_spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pickit2_spi.c b/pickit2_spi.c index 44db6934d..a0fcbb891 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -202,13 +202,14 @@ static int pickit2_spi_send_command(const struct flashctx *flash, unsigned int w const unsigned char *writearr, unsigned char *readarr) { struct pickit2_spi_data *pickit2_data = flash->mst->spi.data; + const unsigned int total_packetsize = writecnt + readcnt + 20; /* Maximum number of bytes per transaction (including command overhead) is 64. Lets play it safe * and always assume the worst case scenario of 20 bytes command overhead. */ - if (writecnt + readcnt + 20 > CMD_LENGTH) { + if (total_packetsize > CMD_LENGTH) { msg_perr("\nTotal packetsize (%i) is greater than %i supported, aborting.\n", - writecnt + readcnt + 20, CMD_LENGTH); + total_packetsize, CMD_LENGTH); return 1; } -- cgit v1.2.3