From 552e60e5716277351ad8b6ca8a0652d0eeb8d986 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 23 Apr 2020 09:36:12 +0200 Subject: stlinkv3_spi: Avoid division by zero Change-Id: I08c0612f3fea59add9bde2fb3cc5c4b5c3756516 Found-by: Coverity Scan #1412744 Signed-off-by: Patrick Georgi Reviewed-on: https://review.coreboot.org/c/flashrom/+/40653 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Stefan Reinauer Reviewed-by: Edward O'Callaghan --- stlinkv3_spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c index 9e621c27c..114c0cab2 100644 --- a/stlinkv3_spi.c +++ b/stlinkv3_spi.c @@ -491,10 +491,11 @@ int stlinkv3_spi_init(void) speed_str = extract_programmer_param("spispeed"); if (speed_str) { sck_freq_kHz = strtoul(speed_str, &endptr, 0); - if (*endptr) { + if (*endptr || sck_freq_kHz == 0) { msg_perr("The spispeed parameter passed with invalid format: %s\n", speed_str); - msg_perr("Please pass the parameter with a simple number in kHz\n"); + msg_perr("Please pass the parameter " + "with a simple non-zero number in kHz\n"); free(speed_str); return -1; } -- cgit v1.2.3