From 5905270fc7a8b0b59dbff8f6832c8b42604e04ed Mon Sep 17 00:00:00 2001 From: Shiyu Sun Date: Thu, 21 Jan 2021 16:31:32 +1100 Subject: realtek_mst_i2c_spi.c: Skip return value check for reset function The return value for reset function can not be guaranteed when reset success. There is no way to check if reset success or not. BUG=b:147402710,b:152558985 BRANCH=none TEST=builds Signed-off-by: Shiyu Sun Change-Id: Ia6200f7150db4368c26d8dfe779a9e85184b1b06 Reviewed-on: https://review.coreboot.org/c/flashrom/+/49786 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- realtek_mst_i2c_spi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 3dd1b3666..1bbb71f42 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -433,9 +433,13 @@ static int realtek_mst_i2c_spi_shutdown(void *data) (struct realtek_mst_i2c_spi_data *)data; int fd = realtek_mst_data->fd; if (realtek_mst_data->reset) { - ret |= realtek_mst_i2c_spi_reset_mpu(fd); - if (ret != 0) - msg_perr("%s: MCU failed to reset on tear-down.\n", __func__); + /* + * Return value for reset mpu is not checked since + * the return value is not guaranteed to be 0 on a + * success reset. Currently there is no way to fix + * that. For more details see b:147402710. + */ + realtek_mst_i2c_spi_reset_mpu(fd); } i2c_close(fd); free(data); -- cgit v1.2.3