From 92b17a52a3aaec7e87aabfc6ce5f05726d1000c0 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 4 Oct 2019 18:47:24 +0200 Subject: board_enable: Work around -Wtype-limits issue In case of an empty `board_matches` list (i.e. on non-x86), we checked if the `unsigned i` is smaller 0. Shuffling the computation avoids that problem. Change-Id: I636d73c920a7b7e7507eafe444bab8236d7acb67 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/flashrom/+/35801 Tested-by: build bot (Jenkins) Reviewed-by: Jacob Garber Reviewed-by: Patrick Georgi --- board_enable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board_enable.c b/board_enable.c index 98d6fd05a..a5980eb3c 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2493,7 +2493,7 @@ int selfcheck_board_enables(void) int ret = 0; unsigned int i; - for (i = 0; i < ARRAY_SIZE(board_matches) - 1; i++) { + for (i = 0; i + 1 < ARRAY_SIZE(board_matches); i++) { const struct board_match *b = &board_matches[i]; if (b->vendor_name == NULL || b->board_name == NULL) { msg_gerr("ERROR: Board enable #%d does not define a vendor and board name.\n" -- cgit v1.2.3