From beaf9cd90b96d06f5a724bce42d3f8e4df58ea14 Mon Sep 17 00:00:00 2001 From: Bart De Schuymer Date: Fri, 18 Aug 2023 17:26:28 +0200 Subject: Makefile: Remove a bashism when searching for sphinx-build e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wrongly set to yes. Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Signed-off-by: Bart De Schuymer Reviewed-on: https://review.coreboot.org/c/flashrom/+/77288 Reviewed-by: Peter Marheine Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi Reviewed-by: Jan Samek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bc3eecbfb..bf01d0f8c 100644 --- a/Makefile +++ b/Makefile @@ -250,7 +250,7 @@ HAS_LINUX_MTD := $(call c_compile_test, Makefile.d/linux_mtd_test.c) HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c) HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c) HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) -HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) &>/dev/null && echo yes || echo no) +HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) >/dev/null 2>/dev/null && echo yes || echo no) EXEC_SUFFIX := $(strip $(if $(filter $(TARGET_OS), DOS MinGW), .exe)) override CFLAGS += -Iinclude -- cgit v1.2.3