From ef78de4a21323b8c459337356289218211f2c5ce Mon Sep 17 00:00:00 2001 From: Elyes HAOUAS Date: Thu, 18 Jul 2019 15:08:10 +0200 Subject: cli_classic: Fix Memory leak Found-by: scan-build 7.0.1-8 Change-Id: I84e642b57b95953f376569e443ef8d8eda7bf98f Signed-off-by: Elyes HAOUAS Reviewed-on: https://review.coreboot.org/c/flashrom/+/34405 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- cli_classic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cli_classic.c b/cli_classic.c index b79f953cb..0591bfeba 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -383,6 +383,11 @@ int main(int argc, char *argv[]) fprintf(stderr, "Log file not supported in standalone mode. Aborting.\n"); cli_classic_abort_usage(); #else /* STANDALONE */ + if (logfile) { + fprintf(stderr, "Warning: -o/--output specified multiple times.\n"); + free(logfile); + } + logfile = strdup(optarg); if (logfile[0] == '\0') { fprintf(stderr, "No log filename specified.\n"); -- cgit v1.2.3