From fac2bfe54caa162f5c6109c5f5c471471e81cc22 Mon Sep 17 00:00:00 2001 From: Thomas Heijligen Date: Mon, 25 Oct 2021 21:38:43 +0200 Subject: pony_spi: fix memory leak Free data if sp_openserport() fails and pony_spi_init() returns early with 1. Change-Id: I11858bd0bdfe8b6d03af616fe4be4fb047b8dcd9 Signed-off-by: Thomas Heijligen Reviewed-on: https://review.coreboot.org/c/flashrom/+/58583 Reviewed-by: Angel Pons Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- pony_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pony_spi.c b/pony_spi.c index 6005bd4c2..86ef238cf 100644 --- a/pony_spi.c +++ b/pony_spi.c @@ -145,6 +145,7 @@ static int pony_spi_init(void) sp_fd = sp_openserport(arg, 9600); if (sp_fd == SER_INV_FD) { free(arg); + free(data); return 1; } if (register_shutdown(pony_spi_shutdown, data) != 0) { -- cgit v1.2.3